-
-
Notifications
You must be signed in to change notification settings - Fork 58
chore(CI): use new release workflow #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fi3ework
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on web-infra-dev/rsbuild@058993d, is there a need to restrict the "latest" dist-tag to only trigger on the main branch? This would prevent packages from being published before a PR is merged, meaning that publishing an npm package would require review by others to prevent accidental publishing.
CodSpeed Performance ReportMerging #592 will not alter performanceComparing Summary
|
Because other PRs may be merged after the merge and before the release, we cannot guarantee that the commit being released is the final release commit. We can adjust our approach in the future based on the situation. |
Summary
The new release workflow is the same as Rsbuild and Rspress, see https://github.com/web-infra-dev/rsbuild/blob/main/.github/workflows/release.yml.
GITHUB_TOKENis no longer required in this workflow.bench-pr.ymlis deleted. We can add it back if it still need to be used.Checklist